refactor(codegen): migrate array-allocator to typeof() (phase-e step 5, pr2)#575
Merged
refactor(codegen): migrate array-allocator to typeof() (phase-e step 5, pr2)#575
Conversation
…or cache first, falls through to resolver
Contributor
Benchmark Results (Linux x86-64)
CLI Tool Benchmarks
|
This was referenced Apr 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters for users
Part of Phase E's type-resolver consolidation. Each migrated site is one less place where two codegen paths can disagree about an expression's type and silently produce wrong native code. No user-visible behavior change in this PR — it's a mechanical swap that routes a query through the annotator's pre-populated cache.
Change
ArrayAllocator.buildInterfaceElementInfoformerly calledctx.resolveExpressionTypeRich(expr)directly. Now callsctx.typeOf(expr)— same semantics (returnsResolvedType | null), but hits the annotator cache first, only falling through toresolveExpressionTypeRichfor expressions the annotator skipped (unknown-base).Interface
ArrayAllocatorContextupdated accordingly.Verification
Full
npm run verify(tests + stage 2 self-host) green locally.Scope
One call site. First consumer migration following the Step-5 annotator landing in #573. More migrations land in subsequent PRs.